Login   Register  
PHP Classes
elePHPant
Icontem

The coding style and the design of the class is below mediocre.

Recommend this page to a friend!
Stumble It! Stumble It! Bookmark in del.icio.us Bookmark in del.icio.us

      PHP GPS Locator  >  All threads  >  The coding style and the design of the class is below mediocre.  >  (Un) Subscribe thread alerts  
Subject:The coding style and the design of the class is below mediocre.
Summary:Package rating comment
Messages:1
Author:Radu Popescu
Date:2009-01-16 21:53:46
 

Radu Popescu rated this package as follows:

Utility: Insufficient
Consistency: Bad
Examples: Sufficient

  1. The coding style and the design of the class is below mediocre.   Reply   Report abuse  
Picture of Radu Popescu
Radu Popescu
2009-01-16 21:53:46
The coding style and the design of the class is below mediocre. It's downright bad.
The classes provide a NMEA parser that at the same time mixes into its functionality Windows port connection and MySQL database stuff.
It's reusability, code-wise, is converging to 0 fast. The coding style and comments are also very poor and not in English, respectively.
I would recommend a full re-write, preceded by a period of at least 5 minutes of thinking about reusability of the components and their relationships (i.e. port connection versus database storage versus NMEA input parsing etc.)