PHP Classes

Bugfixes

Recommend this page to a friend!

      Format Converter  >  All threads  >  Bugfixes  >  (Un) Subscribe thread alerts  
Subject:Bugfixes
Summary:A couple of issues arised from use of this class
Messages:1
Author:Timofey Vorobyov
Date:2008-05-16 12:40:19
 

  1. Bugfixes   Reply   Report abuse  
Picture of Timofey Vorobyov Timofey Vorobyov - 2008-05-16 12:40:19
ffmpeg.php @727

/**
* Adds a command to be bundled into the ffmpeg command call.
* (SPECIAL NOTE; None of the arguments are checked or sanitised by this function. BE CAREFULL if manually using this. The commands and arguments are escapped
* however it is still best to check and santise any params given to this function)
*
* @param string $command
* @param mixed $argument
* @return boolean
*/
public function addCommand($command, $argument='')
{
$this->commands[$command] = ($argument == '') ? '' : escapeshellarg($argument);
return TRUE;
}

/* changes summary:
+ added special treatment of an empty argument, since an escaped empty string becomes '', which behaves badly on some systems
*/


ffmpeg.php@553
// BUGFIX - space added after -y
$exec_string = $this->_prepareCommand(FFMPEG_BINARY, '-i '.$this->commands['-i'].' '.$command_string, (isset($this->commands['-y']) ? '-y ' : '').$this->output_address);