Rupom Razzaque - 2010-02-10 15:15:54 - In reply to message 1 from Timo Witte
What do you mean by "pure shit"? Try to understand its importance first. Lots people sent me good comments about this class. You may suggest me to modify this class, that would be appreciated. But you cant comment this way.
Rupom Razzaque - 2010-02-10 16:00:57 - In reply to message 3 from Timo Witte
any suggestion is fine. thanks for your suggestion. but i don't see anything new in your code - you just converted 2 lines into one or so. simplicity is the best. my code targets the poorest developer who started PHP yesterday.
this class has few methods, not one. but a class can even consist only one method (should not call "function" when it is part of class).
Zafar Iqbal - 2010-02-11 17:40:35 - In reply to message 3 from Timo Witte
Your initial feedback is not exactly constructive. And very harsh. Your second message is more fair.
The best thing would be to contribute to the basic class and improve it.
And there is room for improvement. The original class and your function have serious flaws that would not help even a beginner programmer because it would confuse them more when the code breaks. They would rather do it from scratch and have something working and learn from writing their own code.