PHP Classes
elePHPant
Icontem

This class is simply wrong.

Recommend this page to a friend!

      SQL File Query Extractor  >  All threads  >  This class is simply wrong.  >  (Un) Subscribe thread alerts  
Subject:This class is simply wrong.
Summary:Package rating comment
Messages:1
Author:Lord Pas
Date:2008-09-02 00:26:28
 

 

Lord Pas rated this package as follows:

Utility: Bad
Consistency: Sufficient

  1. This class is simply wrong.   Reply   Report abuse  
Lord Pas - 2008-09-02 00:26:28
This class is simply wrong.

- lack of mbstring support (what about multibyte characters that contain a byte that can be interpreted as a semicolon?)
- lack of careful examination of queries for semicolons in string literals (and for that one has to handle literals, and for that apostrophes and quotation marks, and escaped forms of them)
- can't handle files bigger than 32K
- lack of proper English comments/documentation

I hope you see this as a constructive criticism.